thor/jira
1
0
Fork 0
mirror of https://github.com/Threnklyn/jira.git synced 2026-06-13 16:13:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

prefer defer resp.Body.Close to avoid leaks on subsequent errors

Browse Source
This commit is contained in:
Cory Bennett
2019-05-25 14:09:48 -07:00
parent 954a97eca3
commit a6bf26052c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
search.go
+1 -1
View File
@@ -91,6 +91,7 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer resp.Body.Close()
if resp.StatusCode != 200 { if resp.StatusCode != 200 {
return nil, responseError(resp) return nil, responseError(resp)
@@ -107,7 +108,6 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search
if len(issues) == results.Total || results.Total == 0 { if len(issues) == results.Total || results.Total == 0 {
break break
} }
resp.Body.Close()
} }
results.Issues = issues results.Issues = issues
return results, nil return results, nil