From a6bf26052c1a7a78501cd7ec5eff0004730af092 Mon Sep 17 00:00:00 2001 From: Cory Bennett Date: Sat, 25 May 2019 14:09:48 -0700 Subject: [PATCH] prefer defer resp.Body.Close to avoid leaks on subsequent errors --- search.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/search.go b/search.go index 8983c3d..9f4d347 100644 --- a/search.go +++ b/search.go @@ -91,6 +91,7 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search if err != nil { return nil, err } + defer resp.Body.Close() if resp.StatusCode != 200 { return nil, responseError(resp) @@ -107,7 +108,6 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search if len(issues) == results.Total || results.Total == 0 { break } - resp.Body.Close() } results.Issues = issues return results, nil