thor/esphome-dev
1
0
Fork 0
mirror of https://github.com/Threnklyn/esphome-dev.git synced 2026-05-18 20:23:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix PIDController::in_deadband() to give correct result when error is zero (#5078)

Browse Source
This commit is contained in:
Lewis Baker
2023-07-13 06:27:45 +09:30
committed by GitHub
parent a539197bc4
commit 9344d85414
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/pid/pid_controller.cpp
+1 -1
View File
@@ -29,7 +29,7 @@ float PIDController::update(float setpoint, float process_value) {
bool PIDController::in_deadband() {
// return (fabs(error) < deadband_threshold);
float err = -error_;
return ((err > 0 && err < threshold_high_) || (err < 0 && err > threshold_low_));
return (threshold_low_ < err && err < threshold_high_);
}
void PIDController::calculate_proportional_term_() {