From 664c5cad246cbd4c861b615eb567d3874151d1a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sun, 26 May 2019 21:20:29 +0100
Subject: [PATCH] CI: test on Go 1.12.x, cleanup

We can also use the apt addon to install packages. We also don't need
fast_finish, since we don't use allow_failures anywhere.

Finally, the 'go get' line was pointless, as all dependencies are
vendored, and 'go test' will catch build failures.
---
 .travis.yml             | 21 ++++++++++-----------
 jiracmd/componentAdd.go |  3 +--
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 8a3a891..ac70dc0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,19 +1,18 @@
-sudo: true
-before_install:
-    - sudo apt-get update && sudo apt-get install -y pass gnupg
+addons:
+  apt:
+    packages:
+    - pass
+    - gnupg
 
 language: go
-go_import_path: gopkg.in/Netflix-Skunkworks/go-jira.v1
-go:
-  - 1.9
 
-matrix:
-  fast_finish: true
-  
+go_import_path: gopkg.in/Netflix-Skunkworks/go-jira.v1
+
+go:
+  - 1.12.x
+
 script:
-  - go get -t -v ./...
   - go test ./...
   - go vet -composites=false ./...
   - make
   - make prove 2>&1
-  
diff --git a/jiracmd/componentAdd.go b/jiracmd/componentAdd.go
index d17eb6b..2612b78 100644
--- a/jiracmd/componentAdd.go
+++ b/jiracmd/componentAdd.go
@@ -52,9 +52,8 @@ func CmdComponentAddUsage(cmd *kingpin.CmdClause, opts *ComponentAddOptions) err
 func CmdComponentAdd(o *oreo.Client, globals *jiracli.GlobalOptions, opts *ComponentAddOptions) error {
 	var err error
 	component := &jiradata.Component{}
-	var resp *jiradata.Component
 	err = jiracli.EditLoop(&opts.CommonOptions, &opts.Component, component, func() error {
-		resp, err = jira.CreateComponent(o, globals.Endpoint.Value, component)
+		_, err = jira.CreateComponent(o, globals.Endpoint.Value, component)
 		return err
 	})
 	if err != nil {