prefer defer resp.Body.Close to avoid leaks on subsequent errors

This commit is contained in:
Cory Bennett
2019-05-25 14:09:48 -07:00
parent f6809e32f4
commit 181bd74f1b
+1 -1
View File
@@ -91,6 +91,7 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search
if err != nil {
return nil, err
}
defer resp.Body.Close()
if resp.StatusCode != 200 {
return nil, responseError(resp)
@@ -107,7 +108,6 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider) (*jiradata.Search
if len(issues) == results.Total || results.Total == 0 {
break
}
resp.Body.Close()
}
results.Issues = issues
return results, nil