Run clang-tidy against Arduino 3 (#2146)

* Add macros header with more usable Arduino version defines

* Change Arduino version checking to use our version defines

* Add missing ESP8266 check

* Rename Arduino version macro to ARDUINO_VERSION_CODE

* Upgrade clang-tidy to use Arduino 3

* Fix clang-tidy warnings

* Upgrade NeoPixelBus to upstream 2.6.7

* Use Arduino-version-appropriate API to set redirect flags

* Remove now unnecessary CLANG_TIDY ifdefs

* Add preprocessor hackery to avoid including pgmspace.h

* Bump base image to 4.1.1 and update lint

* Fix nfctag

* Fix make_unique ambiguous

* Fix ignore name

* Fix ambiguous v2

* Remove unused begin

* Cast time_t to prevent issues on platforms where time_t is 32bit

Co-authored-by: Otto winter <otto@otto-winter.com>

platformio.ini

@@ -30,7 +30,7 @@ lib_deps =
     ArduinoJson-esphomelib@5.13.3
     esphome/ESPAsyncWebServer-esphome@1.3.0
     FastLED@3.3.2
-    NeoPixelBus-esphome@2.6.2
+    NeoPixelBus@2.6.7
     1655@1.0.2  ; TinyGPSPlus (has name conflict)
     6865@1.0.0  ; TM1651 Battery Display
     6306@1.0.3  ; HM3301
@@ -47,8 +47,7 @@ src_filter =
     +<.temp/all-include.cpp>
 
 [common:esp8266]
-; use Arduino framework v2.4.2 for clang-tidy (latest 2.5.2 breaks static code analysis, see #760)
-platform = platformio/espressif8266@1.8.0
+platform = platformio/espressif8266@3.1.0
 framework = arduino
 board = nodemcuv2
 lib_deps =