Cleanup dashboard JS (#491)

* Cleanup dashboard JS

* Add vscode

* Save start_mark/end_mark

* Updates

* Updates

* Remove need for cv.nameable

It's a bit hacky but removes so much bloat from integrations

* Add enum helper

* Document APIs, and Improvements

* Fixes

* Fixes

* Update PULL_REQUEST_TEMPLATE.md

* Updates

* Updates

* Updates

esphome/components/uart/switch/__init__.py

@@ -1,7 +1,7 @@
 import esphome.codegen as cg
 import esphome.config_validation as cv
 from esphome.components import switch, uart
-from esphome.const import CONF_DATA, CONF_ID, CONF_INVERTED, CONF_NAME
+from esphome.const import CONF_DATA, CONF_ID, CONF_INVERTED
 from esphome.core import HexInt
 from esphome.py_compat import text_type, binary_type, char_to_byte
 from .. import uart_ns
@@ -21,18 +21,20 @@ def validate_data(value):
     raise cv.Invalid("data must either be a string wrapped in quotes or a list of bytes")
 
 
-CONFIG_SCHEMA = cv.nameable(switch.SWITCH_SCHEMA.extend({
-    cv.GenerateID(): cv.declare_variable_id(UARTSwitch),
+CONFIG_SCHEMA = switch.SWITCH_SCHEMA.extend({
+    cv.GenerateID(): cv.declare_id(UARTSwitch),
     cv.Required(CONF_DATA): validate_data,
     cv.Optional(CONF_INVERTED): cv.invalid("UART switches do not support inverted mode!"),
-}).extend(uart.UART_DEVICE_SCHEMA))
+}).extend(uart.UART_DEVICE_SCHEMA).extend(cv.COMPONENT_SCHEMA)
 
 
 def to_code(config):
-    data = config[CONF_DATA]
-    if isinstance(data, binary_type):
-        data = [HexInt(char_to_byte(x)) for x in data]
-    var = cg.new_Pvariable(config[CONF_ID], config[CONF_NAME], data)
+    var = cg.new_Pvariable(config[CONF_ID])
     yield cg.register_component(var, config)
     yield switch.register_switch(var, config)
     yield uart.register_uart_device(var, config)
+
+    data = config[CONF_DATA]
+    if isinstance(data, binary_type):
+        data = [HexInt(char_to_byte(x)) for x in data]
+    cg.add(var.set_data(data))

esphome/components/uart/switch/uart_switch.cpp

@@ -6,9 +6,6 @@ namespace uart {
 
 static const char *TAG = "uart.switch";
 
-UARTSwitch::UARTSwitch(const std::string &name, const std::vector<uint8_t> &data)
-    : switch_::Switch(name), data_(data) {}
-
 void UARTSwitch::write_state(bool state) {
   if (!state) {
     this->publish_state(false);

esphome/components/uart/switch/uart_switch.h

@@ -9,7 +9,7 @@ namespace uart {
 
 class UARTSwitch : public switch_::Switch, public UARTDevice, public Component {
  public:
-  UARTSwitch(const std::string &name, const std::vector<uint8_t> &data);
+  void set_data(const std::vector<uint8_t> &data) { data_ = data; }
 
   void dump_config() override;