Cleanup dashboard JS (#491)

* Cleanup dashboard JS

* Add vscode

* Save start_mark/end_mark

* Updates

* Updates

* Remove need for cv.nameable

It's a bit hacky but removes so much bloat from integrations

* Add enum helper

* Document APIs, and Improvements

* Fixes

* Fixes

* Update PULL_REQUEST_TEMPLATE.md

* Updates

* Updates

* Updates

esphome/components/gpio/binary_sensor/__init__.py

@@ -2,20 +2,21 @@ import esphome.codegen as cg
 import esphome.config_validation as cv
 from esphome import pins
 from esphome.components import binary_sensor
-from esphome.const import CONF_ID, CONF_NAME, CONF_PIN
+from esphome.const import CONF_ID, CONF_PIN
 from .. import gpio_ns
 
 GPIOBinarySensor = gpio_ns.class_('GPIOBinarySensor', binary_sensor.BinarySensor, cg.Component)
 
-CONFIG_SCHEMA = cv.nameable(binary_sensor.BINARY_SENSOR_SCHEMA.extend({
-    cv.GenerateID(): cv.declare_variable_id(GPIOBinarySensor),
+CONFIG_SCHEMA = binary_sensor.BINARY_SENSOR_SCHEMA.extend({
+    cv.GenerateID(): cv.declare_id(GPIOBinarySensor),
     cv.Required(CONF_PIN): pins.gpio_input_pin_schema
-}).extend(cv.COMPONENT_SCHEMA))
+}).extend(cv.COMPONENT_SCHEMA)
 
 
 def to_code(config):
+    var = cg.new_Pvariable(config[CONF_ID])
+    yield cg.register_component(var, config)
+    yield binary_sensor.register_binary_sensor(var, config)
+
     pin = yield cg.gpio_pin_expression(config[CONF_PIN])
-    rhs = GPIOBinarySensor.new(config[CONF_NAME], pin)
-    gpio = cg.Pvariable(config[CONF_ID], rhs)
-    yield cg.register_component(gpio, config)
-    yield binary_sensor.register_binary_sensor(gpio, config)
+    cg.add(var.set_pin(pin))

esphome/components/gpio/binary_sensor/gpio_binary_sensor.cpp

@@ -19,8 +19,6 @@ void GPIOBinarySensor::dump_config() {
 void GPIOBinarySensor::loop() { this->publish_state(this->pin_->digital_read()); }
 
 float GPIOBinarySensor::get_setup_priority() const { return setup_priority::HARDWARE; }
-GPIOBinarySensor::GPIOBinarySensor(const std::string &name, GPIOPin *pin)
-    : binary_sensor::BinarySensor(name), pin_(pin) {}
 
 }  // namespace gpio
 }  // namespace esphome

esphome/components/gpio/binary_sensor/gpio_binary_sensor.h

@@ -8,8 +8,7 @@ namespace gpio {
 
 class GPIOBinarySensor : public binary_sensor::BinarySensor, public Component {
  public:
-  explicit GPIOBinarySensor(const std::string &name, GPIOPin *pin);
-
+  void set_pin(GPIOPin *pin) { pin_ = pin; }
   // ========== INTERNAL METHODS ==========
   // (In most use cases you won't need these)
   /// Setup pin